Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a pre-allocation guard in Image::printIFDStructure to prevent integer overflow leading to undersized allocations that can bypass the existing allocate64 > io.size() check.
Changes:
- Introduces a new upper-bound check on
countbefore computing(size * count) + pad + 20. - Throws
kerInvalidMallocearlier when the bound is exceeded.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
if (count * size) is very large, (count*size) + 20 can be a very small number, passing the overflow check.
dirkmueller
force-pushed
the
avoid_overflow
branch
from
4f086e7 to
67936d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if (count * size) is very large, (count*size) + 20 can be a very small number, passing the overflow check.